From 95011d4e018c9499c8a4739bc728e38ddc12b9e1 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Wed, 8 Feb 2017 09:32:24 -0800 Subject: [PATCH] crypto/x509: sort the list of fields used by CreateCertificate. Change-Id: I20f4419ca377ee9428075e42db0bad46a75d983f Reviewed-on: https://go-review.googlesource.com/36557 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/crypto/x509/x509.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/crypto/x509/x509.go b/src/crypto/x509/x509.go index efcef8187c..1c5f937c1d 100644 --- a/src/crypto/x509/x509.go +++ b/src/crypto/x509/x509.go @@ -1707,10 +1707,11 @@ func signingParamsForPublicKey(pub interface{}, requestedSigAlgo SignatureAlgori } // CreateCertificate creates a new certificate based on a template. The -// following members of template are used: SerialNumber, Subject, NotBefore, -// NotAfter, KeyUsage, ExtKeyUsage, UnknownExtKeyUsage, BasicConstraintsValid, -// IsCA, MaxPathLen, SubjectKeyId, DNSNames, PermittedDNSDomainsCritical, -// PermittedDNSDomains, SignatureAlgorithm, AuthorityKeyId. +// following members of template are used: AuthorityKeyId, +// BasicConstraintsValid, DNSNames, ExtKeyUsage, IsCA, KeyUsage, MaxPathLen, +// NotAfter, NotBefore, PermittedDNSDomains, PermittedDNSDomainsCritical, +// SerialNumber, SignatureAlgorithm, Subject, SubjectKeyId, and +// UnknownExtKeyUsage. // // The certificate is signed by parent. If parent is equal to template then the // certificate is self-signed. The parameter pub is the public key of the -- 2.50.0