From 956af978806749448af86d7e2878405ee0bef94d Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Tue, 23 Oct 2018 07:01:35 +1100 Subject: [PATCH] encoding/gob: delete out of memory test Now that the library allows much larger data, it can kill machines with less memory. Fixes #28321 Change-Id: I98e1a5fdf812fd75adfb22bf01542423de405fe2 Reviewed-on: https://go-review.googlesource.com/c/143817 Reviewed-by: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov --- src/encoding/gob/encoder_test.go | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/encoding/gob/encoder_test.go b/src/encoding/gob/encoder_test.go index dc9bbcf35d..825f0d6f03 100644 --- a/src/encoding/gob/encoder_test.go +++ b/src/encoding/gob/encoder_test.go @@ -10,7 +10,6 @@ import ( "fmt" "io/ioutil" "reflect" - "runtime" "strings" "testing" ) @@ -1128,24 +1127,3 @@ func TestBadData(t *testing.T) { } } } - -// TestHugeWriteFails tests that enormous messages trigger an error. -func TestHugeWriteFails(t *testing.T) { - if runtime.GOARCH == "wasm" { - t.Skip("out of memory on wasm") - } - if testing.Short() { - // Requires allocating a monster, so don't do this from all.bash. - t.Skip("skipping huge allocation in short mode") - } - huge := make([]byte, tooBig) - huge[0] = 7 // Make sure it's not all zeros. - buf := new(bytes.Buffer) - err := NewEncoder(buf).Encode(huge) - if err == nil { - t.Fatalf("expected error for huge slice") - } - if !strings.Contains(err.Error(), "message too big") { - t.Fatalf("expected 'too big' error; got %s\n", err.Error()) - } -} -- 2.48.1