From 97019105884ced2c4658f9763528e7f6983f8773 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 13 Jun 2020 12:28:08 +1000 Subject: [PATCH] image/gif: speed up initializing test image The benchmark throughput numbers don't change, but the set-up time (the time taken before the b.ResetTimer() call) drops from 460ms to 4ms. Change-Id: I5a6756643dff6127f6d902455d83459c084834fc Reviewed-on: https://go-review.googlesource.com/c/go/+/237757 Reviewed-by: Rob Pike Run-TryBot: Rob Pike TryBot-Result: Gobot Gobot --- src/image/gif/writer_test.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/image/gif/writer_test.go b/src/image/gif/writer_test.go index b619961787..9b15c8d99d 100644 --- a/src/image/gif/writer_test.go +++ b/src/image/gif/writer_test.go @@ -657,7 +657,6 @@ func TestEncodeWrappedImage(t *testing.T) { } func BenchmarkEncode(b *testing.B) { - bo := image.Rect(0, 0, 640, 480) rnd := rand.New(rand.NewSource(123)) // Restrict to a 256-color paletted image to avoid quantization path. @@ -671,10 +670,8 @@ func BenchmarkEncode(b *testing.B) { } } img := image.NewPaletted(image.Rect(0, 0, 640, 480), palette) - for y := bo.Min.Y; y < bo.Max.Y; y++ { - for x := bo.Min.X; x < bo.Max.X; x++ { - img.Set(x, y, palette[rnd.Intn(256)]) - } + for i := range img.Pix { + img.Pix[i] = uint8(rnd.Intn(256)) } b.SetBytes(640 * 480 * 4) -- 2.50.0