From 978616433392369fbe26a189f00b078d2c4856fa Mon Sep 17 00:00:00 2001 From: Cherry Mui Date: Mon, 10 Jul 2023 19:04:57 -0400 Subject: [PATCH] [release-branch.go1.21 cmd/cgo/internal/test: don't pass -lm on darwin On darwin, -lm is not necessary as the math functions are included in libSystem. Passing -lm multiple times results in linker warnings. Don't pass it on darwin. For #61229. Change-Id: I72d8dab1f0eead68cbeb176ac97b8ed1a0cfddab Reviewed-on: https://go-review.googlesource.com/c/go/+/508697 Run-TryBot: Cherry Mui TryBot-Result: Gopher Robot Reviewed-by: Than McIntosh (cherry picked from commit 333c80694c797b5540c959f33c710bc6eba0d141) Reviewed-on: https://go-review.googlesource.com/c/go/+/513758 --- src/cmd/cgo/internal/test/issue8756.go | 2 +- src/cmd/cgo/internal/test/issue8756/issue8756.go | 2 +- src/cmd/cgo/internal/test/test.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cmd/cgo/internal/test/issue8756.go b/src/cmd/cgo/internal/test/issue8756.go index 1ec85a8a5e..817f449e96 100644 --- a/src/cmd/cgo/internal/test/issue8756.go +++ b/src/cmd/cgo/internal/test/issue8756.go @@ -1,7 +1,7 @@ package cgotest /* -#cgo LDFLAGS: -lm +#cgo !darwin LDFLAGS: -lm #include */ import "C" diff --git a/src/cmd/cgo/internal/test/issue8756/issue8756.go b/src/cmd/cgo/internal/test/issue8756/issue8756.go index 5f6b7778ff..223397f067 100644 --- a/src/cmd/cgo/internal/test/issue8756/issue8756.go +++ b/src/cmd/cgo/internal/test/issue8756/issue8756.go @@ -1,7 +1,7 @@ package issue8756 /* -#cgo LDFLAGS: -lm +#cgo !darwin LDFLAGS: -lm #include */ import "C" diff --git a/src/cmd/cgo/internal/test/test.go b/src/cmd/cgo/internal/test/test.go index 8e24f2e618..7da5a856b3 100644 --- a/src/cmd/cgo/internal/test/test.go +++ b/src/cmd/cgo/internal/test/test.go @@ -23,7 +23,7 @@ package cgotest #include #include #include -#cgo LDFLAGS: -lm +#cgo !darwin LDFLAGS: -lm #ifndef WIN32 #include -- 2.48.1