From 983e2fd4e6fecd78789384069c476eead4806d1b Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 14 Sep 2016 18:14:34 +0000 Subject: [PATCH] sort: cut 140 seconds off race build tests No coverage is gained by running the 1e6 versions of the test over the 1e4 versions. It just adds 140 seconds of race overhead time. Updates #17104 Change-Id: I41408aedae34a8b1a148eebdda20269cdefffba3 Reviewed-on: https://go-review.googlesource.com/29159 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Josh Bleecher Snyder --- src/sort/sort_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/sort/sort_test.go b/src/sort/sort_test.go index 60fac2d695..10a2c19684 100644 --- a/src/sort/sort_test.go +++ b/src/sort/sort_test.go @@ -6,10 +6,12 @@ package sort_test import ( "fmt" + "internal/testenv" "math" "math/rand" . "sort" "strconv" + stringspkg "strings" "testing" ) @@ -555,6 +557,9 @@ func TestCountStableOps(t *testing.T) { countOps(t, Stable, "Stable") } func TestCountSortOps(t *testing.T) { countOps(t, Sort, "Sort ") } func bench(b *testing.B, size int, algo func(Interface), name string) { + if stringspkg.HasSuffix(testenv.Builder(), "-race") && size > 1e4 { + b.Skip("skipping slow benchmark on race builder") + } b.StopTimer() data := make(intPairs, size) x := ^uint32(0) -- 2.48.1