From 98da0fb43fb481a25b3b4399cd9f517fe94d9f3f Mon Sep 17 00:00:00 2001 From: Cherry Mui Date: Tue, 6 Dec 2022 12:11:57 -0500 Subject: [PATCH] runtime/pprof: unskip TestTimeVDSO on Android It is possible that CL 455166 fixes this. Try unskipping the test and see. If it fails again we can skip it again. Fixes #48655. Change-Id: Ia81b06cb7608f74adb276bc018e8fc840285bc11 Reviewed-on: https://go-review.googlesource.com/c/go/+/455358 Reviewed-by: Michael Pratt Run-TryBot: Cherry Mui TryBot-Result: Gopher Robot --- src/runtime/pprof/pprof_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/runtime/pprof/pprof_test.go b/src/runtime/pprof/pprof_test.go index 39bc9d11f1..e83eb0015f 100644 --- a/src/runtime/pprof/pprof_test.go +++ b/src/runtime/pprof/pprof_test.go @@ -2262,11 +2262,6 @@ func TestTimeVDSO(t *testing.T) { // Test that time functions have the right stack trace. In particular, // it shouldn't be recursive. - if runtime.GOOS == "android" { - // Flaky on Android, issue 48655. VDSO may not be enabled. - testenv.SkipFlaky(t, 48655) - } - matches := matchAndAvoidStacks(stackContains, []string{"time.now"}, avoidFunctions()) p := testCPUProfile(t, matches, func(dur time.Duration) { t0 := time.Now() -- 2.50.0