From 994b2d46455509f95d60f0abd0d37d3d789f89f2 Mon Sep 17 00:00:00 2001 From: Dave Cheney Date: Fri, 22 May 2015 12:55:47 +1000 Subject: [PATCH] net: fix panic in TestDialerDualStack This change ensures that the test does not try to close dual stack listeners which have not yet been opened. Spotted in crash here http://build.golang.org/log/e5843777df400868ce708b7f00c50dc32c2ec478 Change-Id: I79d513e166effb3e018e2b9dfc23751d92fcbe4b Reviewed-on: https://go-review.googlesource.com/10371 Reviewed-by: Mikio Hara Run-TryBot: Dave Cheney TryBot-Result: Gobot Gobot --- src/net/mockserver_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/mockserver_test.go b/src/net/mockserver_test.go index 62bcfa4022..dd6f4df3b9 100644 --- a/src/net/mockserver_test.go +++ b/src/net/mockserver_test.go @@ -186,7 +186,7 @@ func newDualStackServer(lns []streamListener) (*dualStackServer, error) { for i := range dss.lns { ln, err := Listen(dss.lns[i].network, JoinHostPort(dss.lns[i].address, dss.port)) if err != nil { - for _, ln := range dss.lns { + for _, ln := range dss.lns[:i] { ln.Listener.Close() } return nil, err -- 2.50.0