From 99c1b249b1ffe3b36c5c95572f4497be86b5d727 Mon Sep 17 00:00:00 2001 From: Robert Findley Date: Fri, 8 Oct 2021 10:37:54 -0400 Subject: [PATCH] go/ast, go/types: remove some stale TODOs We've decided to leave TParams on FuncType, and type list syntax is no longer part of the proposal. Change-Id: Id34f6495a358d76994df331384a4b93487275c4d Reviewed-on: https://go-review.googlesource.com/c/go/+/354751 Trust: Robert Findley Run-TryBot: Robert Findley TryBot-Result: Go Bot Reviewed-by: Robert Griesemer --- src/go/ast/ast.go | 2 -- src/go/types/typestring_test.go | 4 ---- 2 files changed, 6 deletions(-) diff --git a/src/go/ast/ast.go b/src/go/ast/ast.go index 70d0912f67..38b6de57d3 100644 --- a/src/go/ast/ast.go +++ b/src/go/ast/ast.go @@ -998,8 +998,6 @@ type ( Name *Ident // function/method name Type *FuncType // function signature: type and value parameters, results, and position of "func" keyword Body *BlockStmt // function body; or nil for external (non-Go) function - // TODO(rFindley) consider storing TParams here, rather than FuncType, as - // they are only valid for declared functions } ) diff --git a/src/go/types/typestring_test.go b/src/go/types/typestring_test.go index ddbb2884b6..5718ffcc6c 100644 --- a/src/go/types/typestring_test.go +++ b/src/go/types/typestring_test.go @@ -98,10 +98,6 @@ var independentTestTypes = []testEntry{ dup("interface{int|float32|complex128}"), dup("interface{int|~float32|~complex128}"), - // TODO(rFindley) uncomment this once this AST is accepted, and add more test - // cases. - // dup(`interface{type int, float32, complex128}`), - // maps dup("map[string]int"), {"map[struct{x, y int}][]byte", "map[struct{x int; y int}][]byte"}, -- 2.50.0