From 9a5a5043e10dbc8338e21b8c7f4081a56a019b7d Mon Sep 17 00:00:00 2001 From: David du Colombier <0intro@gmail.com> Date: Wed, 9 Jan 2019 21:32:11 +0100 Subject: [PATCH] cmd/go: skip tests using Git on Plan 9 TestScript/get_unicode, TestScript/get_dotfiles and TestScript/get_brace are failing on Plan 9 since they expect a full-featured git command, while the git tool has been emulated as a simple rc script on Plan 9. This change skips tests using Git on Plan 9. Fixes #29640. Change-Id: Id7f6fdca552167f4631fe401f63167e5653daafa Reviewed-on: https://go-review.googlesource.com/c/157119 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/go/script_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/go/script_test.go b/src/cmd/go/script_test.go index 4aa92625dd..c56c1fd3e4 100644 --- a/src/cmd/go/script_test.go +++ b/src/cmd/go/script_test.go @@ -283,6 +283,11 @@ Script: if strings.HasPrefix(cond, "exec:") { prog := cond[len("exec:"):] ok = execCache.Do(prog, func() interface{} { + if runtime.GOOS == "plan9" && prog == "git" { + // The Git command is usually not the real Git on Plan 9. + // See https://golang.org/issues/29640. + return false + } _, err := exec.LookPath(prog) return err == nil }).(bool) -- 2.50.0