From 9bfb69187fc76cce47032111f4cbe055a28704ae Mon Sep 17 00:00:00 2001 From: David Symonds Date: Fri, 19 Jul 2013 23:44:22 +1000 Subject: [PATCH] regexp: exclude exhaustive RE2 test from running under race detector. It is an expensive test to run, and even more so with -race, and causes timeouts on builders. It is doubtful that it would find a race that other tests in this package wouldn't, so there is little loss in excluding it. Update #5837. R=golang-dev, dave CC=golang-dev https://golang.org/cl/11568043 --- src/pkg/regexp/exec2_test.go | 20 ++++++++++++++++++++ src/pkg/regexp/exec_test.go | 7 ------- 2 files changed, 20 insertions(+), 7 deletions(-) create mode 100644 src/pkg/regexp/exec2_test.go diff --git a/src/pkg/regexp/exec2_test.go b/src/pkg/regexp/exec2_test.go new file mode 100644 index 0000000000..7b86b41156 --- /dev/null +++ b/src/pkg/regexp/exec2_test.go @@ -0,0 +1,20 @@ +// Copyright 2013 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// +build !race + +package regexp + +import ( + "testing" +) + +// This test is excluded when running under the race detector because +// it is a very expensive test and takes too long. +func TestRE2Exhaustive(t *testing.T) { + if testing.Short() { + t.Skip("skipping TestRE2Exhaustive during short test") + } + testRE2(t, "testdata/re2-exhaustive.txt.bz2") +} diff --git a/src/pkg/regexp/exec_test.go b/src/pkg/regexp/exec_test.go index 9dfaed713f..f6fcd4be4a 100644 --- a/src/pkg/regexp/exec_test.go +++ b/src/pkg/regexp/exec_test.go @@ -67,13 +67,6 @@ func TestRE2Search(t *testing.T) { testRE2(t, "testdata/re2-search.txt") } -func TestRE2Exhaustive(t *testing.T) { - if testing.Short() { - t.Skip("skipping TestRE2Exhaustive during short test") - } - testRE2(t, "testdata/re2-exhaustive.txt.bz2") -} - func testRE2(t *testing.T, file string) { f, err := os.Open(file) if err != nil { -- 2.48.1