From 9cf06ed6cd624ab1d84acbabf30d57b9753651c0 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Thu, 12 Jan 2017 17:35:53 -0500 Subject: [PATCH] cmd/link: only exclude C-only symbols on darwin C-only symbols are excluded from pclntab because of a quirk of darwin, where functions are referred to by an exported symbol so dynamic relocations de-duplicate to the host binary module and break unwinding. This doesn't happen on ELF systems because the linker always refers to unexported module-local symbols, so we don't need this condition. And the current logic for excluding some functions breaks the module verification code in moduledataverify1. So disable this for plugins on linux. (In 1.9, it will probably be necessary to introduce a module-local symbol reference system on darwin to fix a different bug, so all of this onlycsymbol code made be short-lived.) With this CL, the tests in CL 35116 pass. Change-Id: I517d7ca4427241fa0a91276c462827efb9383be9 Reviewed-on: https://go-review.googlesource.com/35190 Reviewed-by: Michael Hudson-Doyle Run-TryBot: David Crawshaw TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/pcln.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/pcln.go b/src/cmd/link/internal/ld/pcln.go index 1ebd7de662..479425f211 100644 --- a/src/cmd/link/internal/ld/pcln.go +++ b/src/cmd/link/internal/ld/pcln.go @@ -168,7 +168,7 @@ func container(s *Symbol) int { if s == nil { return 0 } - if Buildmode == BuildmodePlugin && onlycsymbol(s) { + if Buildmode == BuildmodePlugin && Headtype == obj.Hdarwin && onlycsymbol(s) { return 1 } // We want to generate func table entries only for the "lowest level" symbols, -- 2.48.1