From 9eef9648005c17681800fdb55ed2404ab769761e Mon Sep 17 00:00:00 2001 From: Richard Musiol Date: Sun, 24 Mar 2019 18:17:43 +0100 Subject: [PATCH] misc/wasm: exit with code 1 if WebAssembly.instantiate fails go_js_wasm_exec was returning with code 0 if WebAssembly.instantiate failed. This made failing tests show as passed. Change-Id: Icfb2f42e9f1c3c70ca4a130a61a63cb305edff32 Reviewed-on: https://go-review.googlesource.com/c/go/+/168885 Run-TryBot: Richard Musiol Reviewed-by: Brad Fitzpatrick Reviewed-by: Cherry Zhang TryBot-Result: Gobot Gobot --- misc/wasm/wasm_exec.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/wasm/wasm_exec.js b/misc/wasm/wasm_exec.js index e939e8527a..29427d91e5 100644 --- a/misc/wasm/wasm_exec.js +++ b/misc/wasm/wasm_exec.js @@ -477,7 +477,7 @@ !global.process.versions.electron ) { if (process.argv.length < 3) { - process.stderr.write("usage: go_js_wasm_exec [wasm binary] [arguments]\n"); + console.error("usage: go_js_wasm_exec [wasm binary] [arguments]"); process.exit(1); } @@ -495,7 +495,8 @@ }); return go.run(result.instance); }).catch((err) => { - throw err; + console.error(err); + process.exit(1); }); } })(); -- 2.50.0