From 9efe7e819d500b4a7027811ff5e86be5007099f4 Mon Sep 17 00:00:00 2001 From: Rick Hudson Date: Mon, 27 Oct 2014 14:12:54 -0400 Subject: [PATCH] [dev.garbage] runtime: Linear map test give false negative due to GC. This test gives a false negative at an observed rate of 1 in a 1000 due to the fact that it runs for < 100 ms. allowing GC pauses to warp the results. Changed the test so that it triggers only if it remains non-linear for much larger problem sizes. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/164010043 --- test/maplinear.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/maplinear.go b/test/maplinear.go index 06da968ef0..2494becb89 100644 --- a/test/maplinear.go +++ b/test/maplinear.go @@ -45,11 +45,11 @@ func checkLinear(typ string, tries int, f func(n int)) { return } fails++ - if fails == 6 { + if fails == 12 { panic(fmt.Sprintf("%s: too slow: %d inserts: %v; %d inserts: %v\n", typ, n, t1, 2*n, t2)) } - if fails < 4 { + if fails < 10 { n *= 2 } } -- 2.48.1