From 9f4084278fd0038ef4deedab78ee4d7d2bc1a636 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Wed, 1 Oct 2014 21:35:12 +0000 Subject: [PATCH] fmt: fix internal unknownType function This thing should never be called, but before 151960044 it was being called, incorrectly. This is now just a precaution but let's pretend it Fixes #8843 even though that was fixed by 151960044. The test case was already there and ran, another mystery. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/151970043 --- src/fmt/print.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/fmt/print.go b/src/fmt/print.go index 679c577dbd..de69e90fb7 100644 --- a/src/fmt/print.go +++ b/src/fmt/print.go @@ -297,13 +297,13 @@ func parsenum(s string, start, end int) (num int, isnum bool, newi int) { return } -func (p *pp) unknownType(v interface{}) { - if v == nil { +func (p *pp) unknownType(v reflect.Value) { + if !v.IsValid() { p.buf.Write(nilAngleBytes) return } p.buf.WriteByte('?') - p.buf.WriteString(reflect.TypeOf(v).String()) + p.buf.WriteString(v.Type().String()) p.buf.WriteByte('?') } -- 2.50.0