From 9f4433322bcbd584e0366fa77205eb165490db3e Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 21 Nov 2022 11:01:53 -0500 Subject: [PATCH] [release-branch.go1.19] testing: skip flaky TestRaiseException on windows-amd64-2012-* Modify skip rule for TestRaiseException to trigger on both the base builder (windows-amd64-2012) and the oldcc legacy builder (windows-amd64-2012-oldcc) used for 1.18/1.19 testing. Updates #56983. Change-Id: I132f9ddd102666b68ad04cc661fdcc2cd841051a Reviewed-on: https://go-review.googlesource.com/c/go/+/451294 Auto-Submit: Than McIntosh TryBot-Result: Gopher Robot Run-TryBot: Than McIntosh Reviewed-by: Bryan Mills (cherry picked from commit f0331c524e0d8d32c3918d3515ab8413f38dbd56) Reviewed-on: https://go-review.googlesource.com/c/go/+/454035 Reviewed-by: Cherry Mui TryBot-Bypass: Than McIntosh --- src/runtime/syscall_windows_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/syscall_windows_test.go b/src/runtime/syscall_windows_test.go index 37f8f40cfb..f28f3d8b4f 100644 --- a/src/runtime/syscall_windows_test.go +++ b/src/runtime/syscall_windows_test.go @@ -629,7 +629,7 @@ func TestOutputDebugString(t *testing.T) { } func TestRaiseException(t *testing.T) { - if testenv.Builder() == "windows-amd64-2012" { + if strings.HasPrefix(testenv.Builder(), "windows-amd64-2012") { testenv.SkipFlaky(t, 49681) } o := runTestProg(t, "testprog", "RaiseException") -- 2.48.1