From 9f447c20efeaab1e60e1da03feee2fa0935cf95c Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Fri, 16 Sep 2016 11:26:41 -0700 Subject: [PATCH] cmd/compile: remove unused Label fields Updates #16357. Change-Id: I37f04d83134b5e1e7f6ba44eb9a566758ef594d3 Reviewed-on: https://go-review.googlesource.com/29350 Run-TryBot: Matthew Dempsky TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/gc/gen.go | 10 ---------- src/cmd/compile/internal/gc/go.go | 10 ---------- src/cmd/compile/internal/gc/pgen.go | 3 --- 3 files changed, 23 deletions(-) diff --git a/src/cmd/compile/internal/gc/gen.go b/src/cmd/compile/internal/gc/gen.go index 0de0009103..d8873b9f8b 100644 --- a/src/cmd/compile/internal/gc/gen.go +++ b/src/cmd/compile/internal/gc/gen.go @@ -8,9 +8,6 @@ package gc import "fmt" -// TODO: labellist should become part of a "compilation state" for functions. -var labellist []*Label - func Sysfunc(name string) *Node { n := newname(Pkglookup(name, Runtimepkg)) n.Class = PFUNC @@ -182,13 +179,6 @@ func moveToHeap(n *Node) { } } -func clearlabels() { - for _, l := range labellist { - l.Sym.Label = nil - } - labellist = labellist[:0] -} - // make a new Node off the books func tempname(nn *Node, t *Type) { if Curfn == nil { diff --git a/src/cmd/compile/internal/gc/go.go b/src/cmd/compile/internal/gc/go.go index 7ab7815e32..15a179a566 100644 --- a/src/cmd/compile/internal/gc/go.go +++ b/src/cmd/compile/internal/gc/go.go @@ -54,17 +54,7 @@ type Sym struct { } type Label struct { - Sym *Sym Def *Node - Use []*Node - - // for use during gen - Gotopc *obj.Prog // pointer to unresolved gotos - Labelpc *obj.Prog // pointer to code - Breakpc *obj.Prog // pointer to code - Continpc *obj.Prog // pointer to code - - Used bool // for "label defined and not used" error } type SymFlags uint8 diff --git a/src/cmd/compile/internal/gc/pgen.go b/src/cmd/compile/internal/gc/pgen.go index 4a0b35d4a3..fd7ab08a1a 100644 --- a/src/cmd/compile/internal/gc/pgen.go +++ b/src/cmd/compile/internal/gc/pgen.go @@ -338,9 +338,6 @@ func compile(fn *Node) { saveerrors() - // set up domain for labels - clearlabels() - if Curfn.Type.FuncType().Outnamed { // add clearing of the output parameters for _, t := range Curfn.Type.Results().Fields().Slice() { -- 2.48.1