From a1aee55bd17b79edc66a865c02d170ed6296288d Mon Sep 17 00:00:00 2001 From: Dmitriy Vyukov Date: Mon, 17 Feb 2014 06:04:31 +0400 Subject: [PATCH] net/http: close body in benchmarks Is it required? Why don't we do it? R=bradfitz CC=golang-codereviews https://golang.org/cl/61150043 --- src/pkg/net/http/serve_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pkg/net/http/serve_test.go b/src/pkg/net/http/serve_test.go index f826724a16..54e8c24e83 100644 --- a/src/pkg/net/http/serve_test.go +++ b/src/pkg/net/http/serve_test.go @@ -2258,7 +2258,9 @@ func BenchmarkClientServer(b *testing.B) { if err != nil { b.Fatal("Get:", err) } + defer res.Body.Close() all, err := ioutil.ReadAll(res.Body) + res.Body.Close() if err != nil { b.Fatal("ReadAll:", err) } @@ -2301,6 +2303,7 @@ func benchmarkClientServerParallel(b *testing.B, conc int) { continue } all, err := ioutil.ReadAll(res.Body) + res.Body.Close() if err != nil { b.Logf("ReadAll: %v", err) continue @@ -2338,6 +2341,7 @@ func BenchmarkServer(b *testing.B) { log.Panicf("Get: %v", err) } all, err := ioutil.ReadAll(res.Body) + res.Body.Close() if err != nil { log.Panicf("ReadAll: %v", err) } -- 2.48.1