From a2381f59662f8118c5cd78baaa90e8b186947e8f Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Wed, 17 Oct 2018 22:32:27 +1100 Subject: [PATCH] cmd/doc: fix repeated header bug added in previous CL MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit One too many lines was deleted, and it would print a header multiple times. Add a test. Change-Id: I4906b454dbb66193d515ffacf43849ffdc2dede6 Reviewed-on: https://go-review.googlesource.com/c/142937 Reviewed-by: Ralph Corderoy Reviewed-by: Daniel Martí Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot --- src/cmd/doc/doc_test.go | 3 +++ src/cmd/doc/pkg.go | 1 + 2 files changed, 4 insertions(+) diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go index 80fdb5c72e..ec3a50d87d 100644 --- a/src/cmd/doc/doc_test.go +++ b/src/cmd/doc/doc_test.go @@ -733,6 +733,9 @@ func TestDoc(t *testing.T) { failed = true } } + if bytes.Count(output, []byte("TYPES\n")) > 1 { + t.Fatalf("%s: repeating headers", test.name) + } if failed { t.Logf("\n%s", output) } diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go index bb1b998537..680f555f59 100644 --- a/src/cmd/doc/pkg.go +++ b/src/cmd/doc/pkg.go @@ -426,6 +426,7 @@ func (pkg *Package) allDoc() { printHdr := func(s string) { if hdr != s { pkg.Printf("\n%s\n\n", s) + hdr = s } } -- 2.50.0