From a3c1a867e6e8516d031b540a11b3798cef04ffae Mon Sep 17 00:00:00 2001 From: Tim Heckman Date: Tue, 5 Dec 2017 09:21:25 -0800 Subject: [PATCH] net/http: fix unclosed Listener leak in ListenAndServeTLS Fixes #23002 Change-Id: I87e72833757497aff49117dd40629cb7ec49e6e7 Reviewed-on: https://go-review.googlesource.com/81955 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/net/http/server.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/net/http/server.go b/src/net/http/server.go index 5338bee9b5..a46823c704 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -2998,6 +2998,8 @@ func (srv *Server) ListenAndServeTLS(certFile, keyFile string) error { return err } + defer ln.Close() + return srv.ServeTLS(tcpKeepAliveListener{ln.(*net.TCPListener)}, certFile, keyFile) } -- 2.50.0