From a5032bc86c1a661cf3a68d5095c7a86591c62bc1 Mon Sep 17 00:00:00 2001 From: james Date: Thu, 11 Apr 2019 16:18:29 -0400 Subject: [PATCH] os: don't leak file in ExampleOpenFile_append failure path Fixes #31424 Change-Id: I8364578cbc77827552bd764c716f68495ec51547 Reviewed-on: https://go-review.googlesource.com/c/go/+/171763 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/os/example_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/os/example_test.go b/src/os/example_test.go index 8b6566e149..822886f70c 100644 --- a/src/os/example_test.go +++ b/src/os/example_test.go @@ -28,6 +28,7 @@ func ExampleOpenFile_append() { log.Fatal(err) } if _, err := f.Write([]byte("appended some data\n")); err != nil { + f.Close() // ignore error; Write error takes precedence log.Fatal(err) } if err := f.Close(); err != nil { -- 2.48.1