From a56f5a032217e1e28c005886a98054caf7dc8201 Mon Sep 17 00:00:00 2001 From: Klaus Post Date: Sun, 10 Apr 2016 17:16:07 +0200 Subject: [PATCH] compress/flate: improve short writer error test This improves the short version of the writer test. First of all, it has a much quicker setup. Previously that could take up towards 0.5 second. Secondly, it will test all compression levels in short mode as well. Execution time is 1.7s/0.03s for normal/short mode. Change-Id: I275a21f712daff6f7125cc6a493415e86439cb19 Reviewed-on: https://go-review.googlesource.com/21800 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/compress/flate/writer_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/compress/flate/writer_test.go b/src/compress/flate/writer_test.go index 633cadf2b7..e4c5c8cc72 100644 --- a/src/compress/flate/writer_test.go +++ b/src/compress/flate/writer_test.go @@ -86,14 +86,18 @@ func (e *errorWriter) Write(b []byte) (int, error) { // Test if errors from the underlying writer is passed upwards. func TestWriteError(t *testing.T) { buf := new(bytes.Buffer) - for i := 0; i < 1024*1024; i++ { + n := 65536 + if !testing.Short() { + n *= 4 + } + for i := 0; i < n; i++ { buf.WriteString(fmt.Sprintf("asdasfasf%d%dfghfgujyut%dyutyu\n", i, i, i)) } in := buf.Bytes() // We create our own buffer to control number of writes. - copyBuffer := make([]byte, 1024) + copyBuffer := make([]byte, 128) for l := 0; l < 10; l++ { - for fail := 1; fail <= 512; fail *= 2 { + for fail := 1; fail <= 256; fail *= 2 { // Fail after 'fail' writes ew := &errorWriter{N: fail} w, err := NewWriter(ew, l) -- 2.48.1