From a63afe4720e5eb4fbb76baf38a41cbf60e739fd4 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Felix=20Geisend=C3=B6rfer?=
 <felix.geisendoerfer@datadoghq.com>
Date: Tue, 23 May 2023 12:35:48 +0200
Subject: [PATCH] runtime/metrics: add /gc/scan/globals:bytes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

For #56857

Change-Id: I748fd2a33ee76d9a83ea42f2ebf6d9edda243301
Reviewed-on: https://go-review.googlesource.com/c/go/+/497320
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
---
 src/runtime/metrics.go             | 6 ++++++
 src/runtime/metrics/description.go | 5 +++++
 src/runtime/metrics/doc.go         | 3 +++
 3 files changed, 14 insertions(+)

diff --git a/src/runtime/metrics.go b/src/runtime/metrics.go
index ffbb4e4d0f..da189565c5 100644
--- a/src/runtime/metrics.go
+++ b/src/runtime/metrics.go
@@ -189,6 +189,12 @@ func initMetrics() {
 				out.scalar = in.sysStats.gcCyclesDone
 			},
 		},
+		"/gc/scan/globals:bytes": {
+			compute: func(in *statAggregate, out *metricValue) {
+				out.kind = metricKindUint64
+				out.scalar = gcController.globalsScan.Load()
+			},
+		},
 		"/gc/heap/allocs-by-size:bytes": {
 			deps: makeStatDepSet(heapStatsDep),
 			compute: func(in *statAggregate, out *metricValue) {
diff --git a/src/runtime/metrics/description.go b/src/runtime/metrics/description.go
index 8355fc5da0..8275148fdd 100644
--- a/src/runtime/metrics/description.go
+++ b/src/runtime/metrics/description.go
@@ -294,6 +294,11 @@ var allDesc = []Description{
 		Kind:        KindFloat64Histogram,
 		Cumulative:  true,
 	},
+	{
+		Name:        "/gc/scan/globals:bytes",
+		Description: "The total amount of global variable space that is scannable.",
+		Kind:        KindUint64,
+	},
 	{
 		Name:        "/gc/scan/stack:bytes",
 		Description: "The number of bytes of stack that were scanned last GC cycle.",
diff --git a/src/runtime/metrics/doc.go b/src/runtime/metrics/doc.go
index 7f21278450..0392e76677 100644
--- a/src/runtime/metrics/doc.go
+++ b/src/runtime/metrics/doc.go
@@ -216,6 +216,9 @@ Below is the full list of supported metrics, ordered lexicographically.
 		Distribution of individual GC-related stop-the-world pause
 		latencies. Bucket counts increase monotonically.
 
+	/gc/scan/globals:bytes
+		The total amount of global variable space that is scannable.
+
 	/gc/scan/stack:bytes
 		The number of bytes of stack that were scanned last GC cycle.
 
-- 
2.50.0