From a90fc6d2d4b7a1a054de50841a8bebfc2c2668e9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20M=C3=B6hrmann?= Date: Wed, 17 Jan 2018 21:00:26 +0100 Subject: [PATCH] cmd/compile: replace range loop over list of nodes with orderexprlistinplace MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Replace explicit range loop that applies orderexprinplace on a list of nodes with existing helper function orderexprlistinplace. Passes toolstash -cmp. Change-Id: Ic8098ed08cf67f319de3faa83b00a5b73bbde95d Reviewed-on: https://go-review.googlesource.com/88815 Reviewed-by: Daniel Martí Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot --- src/cmd/compile/internal/gc/order.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cmd/compile/internal/gc/order.go b/src/cmd/compile/internal/gc/order.go index 39e36f7c09..b0115fe733 100644 --- a/src/cmd/compile/internal/gc/order.go +++ b/src/cmd/compile/internal/gc/order.go @@ -762,9 +762,7 @@ func orderstmt(n *Node, order *Order) { // hiter contains pointers and needs to be zeroed. prealloc[n] = ordertemp(hiter(n.Type), order, true) } - for i, n1 := range n.List.Slice() { - n.List.SetIndex(i, orderexprinplace(n1, order)) - } + orderexprlistinplace(n.List, order) orderblockNodes(&n.Nbody) order.out = append(order.out, n) cleantemp(t, order) -- 2.50.0