From aa2d4dee60131b4c05d90efbb9a2bc414aea8240 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 25 Mar 2014 15:19:58 -0700 Subject: [PATCH] net/http: disable recently-introduced flaky test on Windows Disable it until it's debugged so it doesn't hide other real problems on Windows. The test was known to be unreliable anyway (which is why it only needed 1 of 20 runs to pass), but apparently it never passes on Windows. Figure out why later. Update #7634 LGTM=alex.brainman R=adg, alex.brainman CC=golang-codereviews https://golang.org/cl/80110043 --- src/pkg/net/http/transport_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pkg/net/http/transport_test.go b/src/pkg/net/http/transport_test.go index a7b461afeb..0eb6e63b36 100644 --- a/src/pkg/net/http/transport_test.go +++ b/src/pkg/net/http/transport_test.go @@ -1840,6 +1840,9 @@ func TestTransportTLSHandshakeTimeout(t *testing.T) { // Trying to repro golang.org/issue/3514 func TestTLSServerClosesConnection(t *testing.T) { defer afterTest(t) + if runtime.GOOS == "windows" { + t.Skip("skipping flaky test on Windows; golang.org/issue/7634") + } closedc := make(chan bool, 1) ts := httptest.NewTLSServer(HandlerFunc(func(w ResponseWriter, r *Request) { if strings.Contains(r.URL.Path, "/keep-alive-then-die") { -- 2.50.0