From aa5de9ebb55bbd5e0a38304f8f8e603b2ec03238 Mon Sep 17 00:00:00 2001 From: Christian Hoeppner Date: Fri, 4 Jul 2025 18:40:42 +0000 Subject: [PATCH] synctest: fix comments for time.Now() in synctests MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Also add a test case to make sure that time.Now() results in the documented date. Change-Id: Ic4cc577eba485b7c6e1a64122da06d7075bbe12e Reviewed-on: https://go-review.googlesource.com/c/go/+/685677 LUCI-TryBot-Result: Go LUCI Auto-Submit: Christian Höppner Reviewed-by: Damien Neil --- src/testing/synctest/example_test.go | 2 +- src/testing/synctest/synctest.go | 2 +- src/testing/synctest/synctest_test.go | 9 +++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/testing/synctest/example_test.go b/src/testing/synctest/example_test.go index 9ecd28d3dd..843377ea88 100644 --- a/src/testing/synctest/example_test.go +++ b/src/testing/synctest/example_test.go @@ -21,7 +21,7 @@ import ( func TestTime(t *testing.T) { synctest.Test(t, func(t *testing.T) { - start := time.Now() // always midnight UTC 2001-01-01 + start := time.Now() // always midnight UTC 2000-01-01 go func() { time.Sleep(1 * time.Nanosecond) t.Log(time.Since(start)) // always logs "1ns" diff --git a/src/testing/synctest/synctest.go b/src/testing/synctest/synctest.go index 0911519aab..ff88c3ec42 100644 --- a/src/testing/synctest/synctest.go +++ b/src/testing/synctest/synctest.go @@ -22,7 +22,7 @@ // // func TestTime(t *testing.T) { // synctest.Test(t, func(t *testing.T) { -// start := time.Now() // always midnight UTC 2001-01-01 +// start := time.Now() // always midnight UTC 2000-01-01 // go func() { // time.Sleep(1 * time.Second) // t.Log(time.Since(start)) // always logs "1s" diff --git a/src/testing/synctest/synctest_test.go b/src/testing/synctest/synctest_test.go index 9c73178750..62f10d1b81 100644 --- a/src/testing/synctest/synctest_test.go +++ b/src/testing/synctest/synctest_test.go @@ -11,6 +11,7 @@ import ( "regexp" "testing" "testing/synctest" + "time" ) // Tests for interactions between synctest bubbles and the testing package. @@ -179,3 +180,11 @@ func runTest(t *testing.T, args []string, f func(), pattern string) { t.Errorf("got output:\n%s\nwant matching:\n%s", out, pattern) } } + +func TestNow(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + if got, want := time.Now(), time.Date(2000, time.January, 1, 0, 0, 0, 0, time.UTC); !got.Equal(want) { + t.Errorf("time.Now() = %v, want %v", got, want) + } + }) +} -- 2.50.0