From aa716e36a6c0656730eeab753eaba9d07aab72e0 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Fri, 3 Feb 2012 14:03:46 +1100 Subject: [PATCH] dashboard: don't send failing Go commits as todos for subrepos R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5608044 --- misc/dashboard/app/build/handler.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/misc/dashboard/app/build/handler.go b/misc/dashboard/app/build/handler.go index 4aa161e8d2..c74c54a98f 100644 --- a/misc/dashboard/app/build/handler.go +++ b/misc/dashboard/app/build/handler.go @@ -215,10 +215,22 @@ func buildTodo(c appengine.Context, builder, packagePath, goHash string) (interf // see if there are any subrepo commits that need to be built at tip. // If so, ask the builder to build a go tree at the tip commit. // TODO(adg): do the same for "weekly" and "release" tags. + tag, err := GetTag(c, "tip") if err != nil { return nil, err } + + // Check that this Go commit builds OK for this builder. + // If not, don't re-build as the subrepos will never get built anyway. + com, err := tag.Commit(c) + if err != nil { + return nil, err + } + if r := com.Result(builder, ""); r != nil && !r.OK { + return nil, nil + } + pkgs, err := Packages(c, "subrepo") if err != nil { return nil, err @@ -233,6 +245,7 @@ func buildTodo(c appengine.Context, builder, packagePath, goHash string) (interf return tag.Commit(c) } } + return nil, nil } -- 2.50.0