From ab067cde34b515172cf51b4c562b2b4ef3cbe587 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Mon, 6 Feb 2017 17:52:26 -0500 Subject: [PATCH] cmd/link: use external linking for PIE by default Now `go test -buildmode=pie std -short` passes on linux/amd64. Updates #18968 Change-Id: Ide21877713e00edc64c1700c950016d6bff8de0e Reviewed-on: https://go-review.googlesource.com/36417 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/config.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cmd/link/internal/ld/config.go b/src/cmd/link/internal/ld/config.go index 7d00ff1675..2656c24317 100644 --- a/src/cmd/link/internal/ld/config.go +++ b/src/cmd/link/internal/ld/config.go @@ -238,6 +238,8 @@ func determineLinkMode(ctxt *Link) { Linkmode = LinkExternal } else if iscgo && externalobj { Linkmode = LinkExternal + } else if Buildmode == BuildmodePIE { + Linkmode = LinkExternal // https://golang.org/issue/18968 } else { Linkmode = LinkInternal } -- 2.51.0