From ab60a7bc18c990513532b4d33c1e2673fb1ea703 Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Wed, 29 May 2024 22:04:04 +0000 Subject: [PATCH] [release-branch.go1.22] cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short CL 589295 only made one of the two tests short, because the other one seemed to be passing consistently in short mode. On the builders, it seems to still fail maybe 30% of the time by taking too long. Disable these tests in short mode. This CL was merged with CL 589295 before cherry-picking. For #67698. Fixes #67715. Change-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15,go1.22-linux-386-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/589495 Auto-Submit: Michael Knyszek Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Commit-Queue: Michael Knyszek Reviewed-on: https://go-review.googlesource.com/c/go/+/591376 --- src/cmd/cgo/internal/testsanitizers/libfuzzer_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/cgo/internal/testsanitizers/libfuzzer_test.go b/src/cmd/cgo/internal/testsanitizers/libfuzzer_test.go index 3f5b1d91c7..85c8f7bbfb 100644 --- a/src/cmd/cgo/internal/testsanitizers/libfuzzer_test.go +++ b/src/cmd/cgo/internal/testsanitizers/libfuzzer_test.go @@ -13,8 +13,13 @@ import ( ) func TestLibFuzzer(t *testing.T) { + // Skip tests in short mode. + if testing.Short() { + t.Skip("libfuzzer tests can take upwards of minutes to run; skipping in short mode") + } testenv.MustHaveGoBuild(t) testenv.MustHaveCGO(t) + goos, err := goEnv("GOOS") if err != nil { t.Fatal(err) -- 2.50.0