From aba6250250d0cdcd1b7a19ca9c6112639eccbb5e Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 13 Jan 2016 19:36:51 +0000 Subject: [PATCH] net/http: clarify ConnState StateActive docs for HTTP/2 Update #13925 Change-Id: I7cd0625fad841eb0e3f364629f9bc225aa2fdce9 Reviewed-on: https://go-review.googlesource.com/18575 Reviewed-by: Andrew Gerrand --- src/net/http/server.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/net/http/server.go b/src/net/http/server.go index bbaf5d2cc6..8d50ffc599 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -2016,6 +2016,11 @@ const ( // and doesn't fire again until the request has been // handled. After the request is handled, the state // transitions to StateClosed, StateHijacked, or StateIdle. + // For HTTP/2, StateActive fires on the transition from zero + // to one active request, and only transitions away once all + // active requests are complete. That means that ConnState + // can not be used to do per-request work; ConnState only notes + // the overall state of the connection. StateActive // StateIdle represents a connection that has finished -- 2.50.0