From ae54cf73cafad51188863dc5eada1b9d6c4d6a95 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 15 Sep 2009 12:42:24 -0700 Subject: [PATCH] last round: non-package code R=r DELTA=127 (38 added, 3 deleted, 86 changed) OCL=34640 CL=34650 --- doc/progs/sortmain.go | 2 +- test/assign.go | 4 + test/bench/chameneosredux.go | 2 +- test/bench/regex-dna.go | 4 +- test/bugs/bug193.go | 1 + test/chan/perm.go | 9 ++ test/decl.go | 1 + test/declbad.go | 7 ++ test/escape.go | 2 +- test/fixedbugs/bug022.go | 1 + test/fixedbugs/bug030.go | 1 + test/fixedbugs/bug047.go | 2 + test/fixedbugs/bug048.go | 1 + test/fixedbugs/bug056.go | 1 + test/fixedbugs/bug065.go | 1 + test/fixedbugs/bug143.go | 9 +- test/fixedbugs/bug146.go | 1 + test/fixedbugs/bug152.go | 2 +- test/fixedbugs/bug173.go | 4 +- test/fixedbugs/bug183.go | 6 +- test/fixedbugs/bug184.go | 2 + test/fixedbugs/bug189.go | 1 + test/fixedbugs/bug201.go | 12 +-- test/fixedbugs/bug204.go | 2 +- test/initialize.go | 2 +- test/mallocrep1.go | 2 +- test/map.go | 111 ++++++++++++------------- test/range.go | 2 +- usr/dsymonds/iterable/iterable_test.go | 2 +- 29 files changed, 116 insertions(+), 81 deletions(-) diff --git a/doc/progs/sortmain.go b/doc/progs/sortmain.go index 3dca963440..63d68ff05c 100644 --- a/doc/progs/sortmain.go +++ b/doc/progs/sortmain.go @@ -55,7 +55,7 @@ func days() { if !sort.IsSorted(&a) { panic() } - for i, d := range data { + for _, d := range data { fmt.Printf("%s ", d.long_name) } fmt.Printf("\n") diff --git a/test/assign.go b/test/assign.go index 9fe9ea0791..acddefef6d 100644 --- a/test/assign.go +++ b/test/assign.go @@ -17,17 +17,21 @@ func main() { { var x, y sync.Mutex; x = y; // ERROR "assignment\[ -~\]*Mutex" + _ = x; } { var x, y T; x = y; // ERROR "assignment\[ -~\]*Mutex" + _ = x; } { var x, y [2]sync.Mutex; x = y; // ERROR "assignment\[ -~\]*Mutex" + _ = x; } { var x, y [2]T; x = y; // ERROR "assignment\[ -~\]*Mutex" + _ = x; } } diff --git a/test/bench/chameneosredux.go b/test/bench/chameneosredux.go index a8cd85454f..e89e69b7dc 100644 --- a/test/bench/chameneosredux.go +++ b/test/bench/chameneosredux.go @@ -175,7 +175,7 @@ func play(ref *Referee, color []Color) { fmt.Printf("\n"); <-ref.done; total := 0; - for i, c := range cham { + for _, c := range cham { total += c.count; fmt.Printf("%d %s\n", c.count, say(c.same)); } diff --git a/test/bench/regex-dna.go b/test/bench/regex-dna.go index 637cb14542..f42efc6d4d 100644 --- a/test/bench/regex-dna.go +++ b/test/bench/regex-dna.go @@ -106,10 +106,10 @@ func main() { // Delete the comment lines and newlines bytes = compile("(>[^\n]+)?\n").ReplaceAll(bytes, []byte{}); clen := len(bytes); - for i, s := range variants { + for _, s := range variants { fmt.Printf("%s %d\n", s, countMatches(s, bytes)); } - for i, sub := range substs { + for _, sub := range substs { bytes = compile(sub.pat).ReplaceAll(bytes, strings.Bytes(sub.repl)); } fmt.Printf("\n%d\n%d\n%d\n", ilen, clen, len(bytes)); diff --git a/test/bugs/bug193.go b/test/bugs/bug193.go index df768b930f..f6b03e13d2 100644 --- a/test/bugs/bug193.go +++ b/test/bugs/bug193.go @@ -12,4 +12,5 @@ func main() { y1 := float(ss); y2 := float(1<= len(a) { println("BUG"); break; diff --git a/test/initialize.go b/test/initialize.go index 5fde9dabaf..807bf5bda2 100644 --- a/test/initialize.go +++ b/test/initialize.go @@ -50,7 +50,7 @@ var same = []Same { func main() { ok := true; - for i, s := range same { + for _, s := range same { if !reflect.DeepEqual(s.a, s.b) { ok = false; fmt.Printf("not same: %v and %v\n", s.a, s.b); diff --git a/test/mallocrep1.go b/test/mallocrep1.go index e78a9ce9ca..2f9900d940 100644 --- a/test/mallocrep1.go +++ b/test/mallocrep1.go @@ -87,7 +87,7 @@ func AllocAndFree(size, count int) { } func atoi(s string) int { - i, xx1 := strconv.Atoi(s); + i, _ := strconv.Atoi(s); return i } diff --git a/test/map.go b/test/map.go index 95da48c75d..d09734a130 100644 --- a/test/map.go +++ b/test/map.go @@ -140,7 +140,6 @@ func main() { s := strconv.Itoa(i); s10 := strconv.Itoa(i*10); f := float(i); - t := T{int64(i), f}; // BUG m := M(i, i+1); if mib[i] != (i != 0) { fmt.Printf("mib[%d] = %t\n", i, mib[i]); @@ -193,133 +192,132 @@ func main() { for i := 0; i < count; i++ { s := strconv.Itoa(i); f := float(i); - t := T{int64(i), f}; { - a, b := mib[i]; + _, b := mib[i]; if !b { fmt.Printf("tuple existence decl: mib[%d]\n", i); } - a, b = mib[i]; + _, b = mib[i]; if !b { fmt.Printf("tuple existence assign: mib[%d]\n", i); } } { - a, b := mii[i]; + _, b := mii[i]; if !b { fmt.Printf("tuple existence decl: mii[%d]\n", i); } - a, b = mii[i]; + _, b = mii[i]; if !b { fmt.Printf("tuple existence assign: mii[%d]\n", i); } } { - a, b := mfi[f]; + _, b := mfi[f]; if !b { fmt.Printf("tuple existence decl: mfi[%d]\n", i); } - a, b = mfi[f]; + _, b = mfi[f]; if !b { fmt.Printf("tuple existence assign: mfi[%d]\n", i); } } { - a, b := mif[i]; + _, b := mif[i]; if !b { fmt.Printf("tuple existence decl: mif[%d]\n", i); } - a, b = mif[i]; + _, b = mif[i]; if !b { fmt.Printf("tuple existence assign: mif[%d]\n", i); } } { - a, b := mis[i]; + _, b := mis[i]; if !b { fmt.Printf("tuple existence decl: mis[%d]\n", i); } - a, b = mis[i]; + _, b = mis[i]; if !b { fmt.Printf("tuple existence assign: mis[%d]\n", i); } } { - a, b := msi[s]; + _, b := msi[s]; if !b { fmt.Printf("tuple existence decl: msi[%d]\n", i); } - a, b = msi[s]; + _, b = msi[s]; if !b { fmt.Printf("tuple existence assign: msi[%d]\n", i); } } { - a, b := mss[s]; + _, b := mss[s]; if !b { fmt.Printf("tuple existence decl: mss[%d]\n", i); } - a, b = mss[s]; + _, b = mss[s]; if !b { fmt.Printf("tuple existence assign: mss[%d]\n", i); } } { - a, b := mspa[s]; + _, b := mspa[s]; if !b { fmt.Printf("tuple existence decl: mspa[%d]\n", i); } - a, b = mspa[s]; + _, b = mspa[s]; if !b { fmt.Printf("tuple existence assign: mspa[%d]\n", i); } } { - a, b := mipT[i]; + _, b := mipT[i]; if !b { fmt.Printf("tuple existence decl: mipT[%d]\n", i); } - a, b = mipT[i]; + _, b = mipT[i]; if !b { fmt.Printf("tuple existence assign: mipT[%d]\n", i); } } { - a, b := mpTi[apT[i]]; + _, b := mpTi[apT[i]]; if !b { fmt.Printf("tuple existence decl: mpTi[apT[%d]]\n", i); } - a, b = mpTi[apT[i]]; + _, b = mpTi[apT[i]]; if !b { fmt.Printf("tuple existence assign: mpTi[apT[%d]]\n", i); } } { - a, b := mipM[i]; + _, b := mipM[i]; if !b { fmt.Printf("tuple existence decl: mipM[%d]\n", i); } - a, b = mipM[i]; + _, b = mipM[i]; if !b { fmt.Printf("tuple existence assign: mipM[%d]\n", i); } } { - a, b := mit[i]; + _, b := mit[i]; if !b { fmt.Printf("tuple existence decl: mit[%d]\n", i); } - a, b = mit[i]; + _, b = mit[i]; if !b { fmt.Printf("tuple existence assign: mit[%d]\n", i); } } // { -// a, b := mti[t]; +// _, b := mti[t]; // if !b { // fmt.Printf("tuple existence decl: mti[%d]\n", i); // } -// a, b = mti[t]; +// _, b = mti[t]; // if !b { // fmt.Printf("tuple existence assign: mti[%d]\n", i); // } @@ -331,133 +329,132 @@ func main() { for i := count; i < 2*count; i++ { s := strconv.Itoa(i); f := float(i); - t := T{int64(i),f}; { - a, b := mib[i]; + _, b := mib[i]; if b { fmt.Printf("tuple nonexistence decl: mib[%d]", i); } - a, b = mib[i]; + _, b = mib[i]; if b { fmt.Printf("tuple nonexistence assign: mib[%d]", i); } } { - a, b := mii[i]; + _, b := mii[i]; if b { fmt.Printf("tuple nonexistence decl: mii[%d]", i); } - a, b = mii[i]; + _, b = mii[i]; if b { fmt.Printf("tuple nonexistence assign: mii[%d]", i); } } { - a, b := mfi[f]; + _, b := mfi[f]; if b { fmt.Printf("tuple nonexistence decl: mfi[%d]", i); } - a, b = mfi[f]; + _, b = mfi[f]; if b { fmt.Printf("tuple nonexistence assign: mfi[%d]", i); } } { - a, b := mif[i]; + _, b := mif[i]; if b { fmt.Printf("tuple nonexistence decl: mif[%d]", i); } - a, b = mif[i]; + _, b = mif[i]; if b { fmt.Printf("tuple nonexistence assign: mif[%d]", i); } } { - a, b := mis[i]; + _, b := mis[i]; if b { fmt.Printf("tuple nonexistence decl: mis[%d]", i); } - a, b = mis[i]; + _, b = mis[i]; if b { fmt.Printf("tuple nonexistence assign: mis[%d]", i); } } { - a, b := msi[s]; + _, b := msi[s]; if b { fmt.Printf("tuple nonexistence decl: msi[%d]", i); } - a, b = msi[s]; + _, b = msi[s]; if b { fmt.Printf("tuple nonexistence assign: msi[%d]", i); } } { - a, b := mss[s]; + _, b := mss[s]; if b { fmt.Printf("tuple nonexistence decl: mss[%d]", i); } - a, b = mss[s]; + _, b = mss[s]; if b { fmt.Printf("tuple nonexistence assign: mss[%d]", i); } } { - a, b := mspa[s]; + _, b := mspa[s]; if b { fmt.Printf("tuple nonexistence decl: mspa[%d]", i); } - a, b = mspa[s]; + _, b = mspa[s]; if b { fmt.Printf("tuple nonexistence assign: mspa[%d]", i); } } { - a, b := mipT[i]; + _, b := mipT[i]; if b { fmt.Printf("tuple nonexistence decl: mipT[%d]", i); } - a, b = mipT[i]; + _, b = mipT[i]; if b { fmt.Printf("tuple nonexistence assign: mipT[%d]", i); } } { - a, b := mpTi[apT[i]]; + _, b := mpTi[apT[i]]; if b { fmt.Printf("tuple nonexistence decl: mpTi[apt[%d]]", i); } - a, b = mpTi[apT[i]]; + _, b = mpTi[apT[i]]; if b { fmt.Printf("tuple nonexistence assign: mpTi[apT[%d]]", i); } } { - a, b := mipM[i]; + _, b := mipM[i]; if b { fmt.Printf("tuple nonexistence decl: mipM[%d]", i); } - a, b = mipM[i]; + _, b = mipM[i]; if b { fmt.Printf("tuple nonexistence assign: mipM[%d]", i); } } // { -// a, b := mti[t]; +// _, b := mti[t]; // if b { // fmt.Printf("tuple nonexistence decl: mti[%d]", i); // } -// a, b = mti[t]; +// _, b = mti[t]; // if b { // fmt.Printf("tuple nonexistence assign: mti[%d]", i); // } // } { - a, b := mit[i]; + _, b := mit[i]; if b { fmt.Printf("tuple nonexistence decl: mit[%d]", i); } - a, b = mit[i]; + _, b = mit[i]; if b { fmt.Printf("tuple nonexistence assign: mit[%d]", i); } @@ -487,10 +484,10 @@ func main() { fmt.Printf("update mipM[%d][%d] = %i\n", i, i, mipM[i][i]); } } - + // test range on nil map var mnil map[string] int; - for x, y := range mnil { + for _, _ = range mnil { panic("range mnil"); } } diff --git a/test/range.go b/test/range.go index 7a8c686350..7abc80c66d 100644 --- a/test/range.go +++ b/test/range.go @@ -42,7 +42,7 @@ func makearray() []int { func testarray() { s := 0; - for k, v := range makearray() { + for _, v := range makearray() { s += v; } if nmake != 1 { diff --git a/usr/dsymonds/iterable/iterable_test.go b/usr/dsymonds/iterable/iterable_test.go index 512cac1398..28bdfb66f7 100644 --- a/usr/dsymonds/iterable/iterable_test.go +++ b/usr/dsymonds/iterable/iterable_test.go @@ -13,7 +13,7 @@ type IntArray []int; func (arr IntArray) Iter() <-chan interface {} { ch := make(chan interface {}); go func() { - for i, x := range arr { + for _, x := range arr { ch <- x } close(ch) -- 2.48.1