From aeee34cb242620ad3d40685227a061818e843a72 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20M=C3=B6hrmann?= Date: Wed, 10 May 2017 19:03:48 +0200 Subject: [PATCH] runtime: remove unused cpuid_X variables MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit They are not exported and not used in the compiler or standard library. Change-Id: Ie1d210464f826742d282f12258ed1792cbd2d188 Reviewed-on: https://go-review.googlesource.com/43135 Run-TryBot: Martin Möhrmann TryBot-Result: Gobot Gobot Reviewed-by: Keith Randall --- src/runtime/asm_386.s | 3 --- src/runtime/asm_amd64.s | 3 --- src/runtime/asm_amd64p32.s | 3 --- src/runtime/runtime2.go | 6 ------ 4 files changed, 15 deletions(-) diff --git a/src/runtime/asm_386.s b/src/runtime/asm_386.s index dc5db91ea8..5bbf2866f3 100644 --- a/src/runtime/asm_386.s +++ b/src/runtime/asm_386.s @@ -76,8 +76,6 @@ notintel: CPUID MOVL CX, DI // Move to global variable clobbers CX when generating PIC MOVL AX, runtime·processorVersionInfo(SB) - MOVL DI, runtime·cpuid_ecx(SB) - MOVL DX, runtime·cpuid_edx(SB) // Check for MMX support TESTL $(1<<23), DX // MMX @@ -116,7 +114,6 @@ eax7: MOVL $7, AX MOVL $0, CX CPUID - MOVL BX, runtime·cpuid_ebx7(SB) TESTL $(1<<3), BX // BMI1 SETNE runtime·support_bmi1(SB) diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s index fb428c40db..6405be92de 100644 --- a/src/runtime/asm_amd64.s +++ b/src/runtime/asm_amd64.s @@ -49,8 +49,6 @@ notintel: MOVL $1, AX CPUID MOVL AX, runtime·processorVersionInfo(SB) - MOVL CX, runtime·cpuid_ecx(SB) - MOVL DX, runtime·cpuid_edx(SB) TESTL $(1<<26), DX // SSE2 SETNE runtime·support_sse2(SB) @@ -85,7 +83,6 @@ eax7: MOVL $7, AX MOVL $0, CX CPUID - MOVL BX, runtime·cpuid_ebx7(SB) TESTL $(1<<3), BX // BMI1 SETNE runtime·support_bmi1(SB) diff --git a/src/runtime/asm_amd64p32.s b/src/runtime/asm_amd64p32.s index e97674cc84..6367b3fef4 100644 --- a/src/runtime/asm_amd64p32.s +++ b/src/runtime/asm_amd64p32.s @@ -46,8 +46,6 @@ notintel: MOVL $1, AX CPUID MOVL AX, runtime·processorVersionInfo(SB) - MOVL CX, runtime·cpuid_ecx(SB) - MOVL DX, runtime·cpuid_edx(SB) TESTL $(1<<26), DX // SSE2 SETNE runtime·support_sse2(SB) @@ -82,7 +80,6 @@ eax7: MOVL $7, AX MOVL $0, CX CPUID - MOVL BX, runtime·cpuid_ebx7(SB) TESTL $(1<<3), BX // BMI1 SETNE runtime·support_bmi1(SB) diff --git a/src/runtime/runtime2.go b/src/runtime/runtime2.go index 8c4d41d928..b0ebfd818c 100644 --- a/src/runtime/runtime2.go +++ b/src/runtime/runtime2.go @@ -746,12 +746,6 @@ var ( support_sse42 bool support_ssse3 bool - // TODO(moehrmann) delete below variables once external - // packages have their dependencies on these removed. - cpuid_ecx uint32 - cpuid_edx uint32 - cpuid_ebx7 uint32 // not set on amd64p32 - goarm uint8 // set by cmd/link on arm systems framepointer_enabled bool // set by cmd/link ) -- 2.48.1