From b3a1205a1133328068f002dd44141cb9efb2127b Mon Sep 17 00:00:00 2001 From: Ayan George Date: Thu, 1 Aug 2019 12:35:59 -0400 Subject: [PATCH] runtime: simplify GOOS detection in mstart() The existing condition is long and repetitive. Using select/case with multiple values in the expression list is more concise and clearer. Change-Id: I43f8abcf958e433468728f1d89ff1436332b29da Reviewed-on: https://go-review.googlesource.com/c/go/+/188519 Reviewed-by: Keith Randall Run-TryBot: Keith Randall TryBot-Result: Gobot Gobot --- src/runtime/proc.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/runtime/proc.go b/src/runtime/proc.go index df98783385..72e6f0da0c 100644 --- a/src/runtime/proc.go +++ b/src/runtime/proc.go @@ -1167,7 +1167,8 @@ func mstart() { mstart1() // Exit this thread. - if GOOS == "windows" || GOOS == "solaris" || GOOS == "illumos" || GOOS == "plan9" || GOOS == "darwin" || GOOS == "aix" { + switch GOOS { + case "windows", "solaris", "illumos", "plan9", "darwin", "aix": // Windows, Solaris, illumos, Darwin, AIX and Plan 9 always system-allocate // the stack, but put it in _g_.stack before mstart, // so the logic above hasn't set osStack yet. -- 2.50.0