From b3b4556c245c8f21872910ee866133428bbb5a60 Mon Sep 17 00:00:00 2001 From: func25 Date: Sun, 23 Jun 2024 05:53:47 +0000 Subject: [PATCH] cmd/compile: update README to reflect dead code elimination changes The description of middle-end dead code elimination is inconsistent with the current implementation. The early dead code elimination pass of IR nodes is no longer located in cmd/compile/internal/deadcode and is no longer called by gc/main.go:Main. It has been moved to the unified IR writer phase. This update modifies the README to reflect this architectural change. Change-Id: I78bd486edefd6b02948fee7de9ce6c83b147bc1d GitHub-Last-Rev: 76493ce8b08cd585d761d65d29b984360f7ee628 GitHub-Pull-Request: golang/go#68134 Reviewed-on: https://go-review.googlesource.com/c/go/+/593638 Reviewed-by: Robert Griesemer Reviewed-by: Keith Randall Reviewed-by: Keith Randall LUCI-TryBot-Result: Go LUCI Auto-Submit: Keith Randall --- src/cmd/compile/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/compile/README.md b/src/cmd/compile/README.md index 3fc7ca6ec6..cffb4e7a80 100644 --- a/src/cmd/compile/README.md +++ b/src/cmd/compile/README.md @@ -63,7 +63,6 @@ Unified IR is also involved in import/export of packages and inlining. ### 4. Middle end -* `cmd/compile/internal/deadcode` (dead code elimination) * `cmd/compile/internal/inline` (function call inlining) * `cmd/compile/internal/devirtualize` (devirtualization of known interface method calls) * `cmd/compile/internal/escape` (escape analysis) @@ -72,6 +71,8 @@ Several optimization passes are performed on the IR representation: dead code elimination, (early) devirtualization, function call inlining, and escape analysis. +The early dead code elimination pass is integrated into the unified IR writer phase. + ### 5. Walk * `cmd/compile/internal/walk` (order of evaluation, desugaring) -- 2.48.1