From b559a173f9f187e1185f8de00a9cc1f5b05aceef Mon Sep 17 00:00:00 2001 From: Neven Sajko Date: Sat, 7 Mar 2020 17:23:20 +0000 Subject: [PATCH] internal/xcoff: fix wrong bit masking comparisons MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit I do not know much about xcoff, but this was probably the intended behavior. (The comparison is tautologically false, as is.) Also note: does any other code even depend on the changed code existing? Maybe it should just be removed, as I did not find any uses of fields that are written to if the branch condition tests true. Change-Id: I1f23d33764df40e87f3e64460d63f6efc51a2a78 GitHub-Last-Rev: 268909130fd7fb3993fcf7004143ec48dbfe5e2a GitHub-Pull-Request: golang/go#37733 Reviewed-on: https://go-review.googlesource.com/c/go/+/222478 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Clément Chigot Reviewed-by: Ian Lance Taylor --- src/internal/xcoff/file.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/internal/xcoff/file.go b/src/internal/xcoff/file.go index 66b5391d58..05e4fd555c 100644 --- a/src/internal/xcoff/file.go +++ b/src/internal/xcoff/file.go @@ -412,10 +412,10 @@ func NewFile(r io.ReaderAt) (*File, error) { sect.Relocs[i].Type = rel.Rtype sect.Relocs[i].Length = rel.Rsize&0x3F + 1 - if rel.Rsize&0x80 == 1 { + if rel.Rsize&0x80 != 0 { sect.Relocs[i].Signed = true } - if rel.Rsize&0x40 == 1 { + if rel.Rsize&0x40 != 0 { sect.Relocs[i].InstructionFixed = true } @@ -428,10 +428,10 @@ func NewFile(r io.ReaderAt) (*File, error) { sect.Relocs[i].Symbol = idxToSym[int(rel.Rsymndx)] sect.Relocs[i].Type = rel.Rtype sect.Relocs[i].Length = rel.Rsize&0x3F + 1 - if rel.Rsize&0x80 == 1 { + if rel.Rsize&0x80 != 0 { sect.Relocs[i].Signed = true } - if rel.Rsize&0x40 == 1 { + if rel.Rsize&0x40 != 0 { sect.Relocs[i].InstructionFixed = true } } -- 2.50.0