From b5aa4789f93be669696f2a9b95eb018b931993d8 Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Wed, 28 Nov 2012 17:00:50 +1100 Subject: [PATCH] net/http: fix broken TestIssue4191_InfiniteGetToPutTimeout Test creates 2 tcp connections for put and get. Make sure these are closed properly after test is over, otherwise server hangs waiting for connection to be closed. R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/6842109 --- src/pkg/net/http/transport_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pkg/net/http/transport_test.go b/src/pkg/net/http/transport_test.go index a594fa81d9..2f4eb88f96 100644 --- a/src/pkg/net/http/transport_test.go +++ b/src/pkg/net/http/transport_test.go @@ -996,9 +996,11 @@ func TestIssue4191_InfiniteGetToPutTimeout(t *testing.T) { req, _ := NewRequest("PUT", ts.URL+"/put", sres.Body) _, err = client.Do(req) if err == nil { + sres.Body.Close() t.Errorf("Unexpected successful PUT") break } + sres.Body.Close() } if debug { println("tests complete; waiting for handlers to finish") -- 2.48.1