From b66474e0217145570fbc38d66b3f11af64586225 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 22 May 2023 11:38:46 -0700 Subject: [PATCH] runtime: treat TestRaceSignal as flaky on Darwin It should be impossible for the program to exit with SIGCHLD, but it happens occasionally. Skip the test on Darwin. For #60316 Change-Id: Idc9d89838e73f077afc42a9703554d61ac7a0069 Reviewed-on: https://go-review.googlesource.com/c/go/+/497055 Reviewed-by: Bryan Mills Run-TryBot: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Auto-Submit: Ian Lance Taylor --- src/runtime/crash_cgo_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 2a07678b52..e3417527c4 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -410,6 +410,9 @@ func TestRaceSignal(t *testing.T) { t.Skipf("skipping: test requires pthread support") // TODO: Can this test be rewritten to use the C11 thread API instead? } + if runtime.GOOS == "darwin" || runtime.GOOS == "ios" { + testenv.SkipFlaky(t, 60316) + } t.Parallel() -- 2.50.0