From b820fb8df11e5ab4068b4ed9522a96bf52cf8b4d Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 10 Nov 2022 09:44:39 -0500 Subject: [PATCH] go/build: in TestImportDirTarget, only expect an install target when cgo is enabled As of CL 448803, packages in GOROOT only have install targets when they have cgo source files. When cgo is not enabled, that condition is necessarily false, and no install target will exist. For #47257. Change-Id: I653a9c5f89d18a5841810f3de8d490bd7cb7e922 Reviewed-on: https://go-review.googlesource.com/c/go/+/449375 Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Michael Matloob Auto-Submit: Bryan Mills --- src/go/build/build_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/go/build/build_test.go b/src/go/build/build_test.go index db50d45d84..3eebfd8e9e 100644 --- a/src/go/build/build_test.go +++ b/src/go/build/build_test.go @@ -681,8 +681,11 @@ func TestImportDirTarget(t *testing.T) { if err != nil { t.Fatal(err) } - if p.PkgTargetRoot == "" || p.PkgObj == "" { - t.Errorf("p.PkgTargetRoot == %q, p.PkgObj == %q, want non-empty", p.PkgTargetRoot, p.PkgObj) + if p.PkgTargetRoot == "" { + t.Errorf("p.PkgTargetRoot == %q, want non-empty", p.PkgTargetRoot) + } + if testenv.HasCGO() && p.PkgObj == "" { + t.Errorf("p.PkgObj == %q, want non-empty", p.PkgObj) } } -- 2.50.0