From b8b48abe0fbd3ce6a1f8332da8ad6b8885a3aa1d Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 2 Aug 2013 10:19:52 -0700 Subject: [PATCH] misc/dist: don't ship cmd/api cmd/api is a tool to prevent the Go developers from breaking the Go 1 API promise. It has no utility to end users and doesn't run on arbitrary packages (it's always been full of hacks for its bespoke type checker to work on the standard library) Robert's in-progress rewrite depends on the go.tools repo for go/types, so we won't be able to ship this tool later anyway. Just remove it from binary distributions. A future change to run.bash can conditionally build & run cmd/api, perhaps automatically fetching go/types if necessary. I assume people don't want to vendor go/types into a private gopath just for cmd/api. I will need help with run.bat. R=golang-dev, adg, dsymonds, rsc CC=golang-dev https://golang.org/cl/12316043 --- misc/dist/bindist.go | 1 + src/run.bash | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/misc/dist/bindist.go b/misc/dist/bindist.go index 754bd280c2..f56a88dc6b 100644 --- a/misc/dist/bindist.go +++ b/misc/dist/bindist.go @@ -50,6 +50,7 @@ const ( var preBuildCleanFiles = []string{ "lib/codereview", "misc/dashboard/godashboard", + "src/cmd/api", "src/cmd/cov", "src/cmd/prof", "src/pkg/exp", diff --git a/src/run.bash b/src/run.bash index 83ef65bf0b..e5f2c384bb 100755 --- a/src/run.bash +++ b/src/run.bash @@ -176,9 +176,12 @@ unset GOMAXPROCS time go run run.go || exit 1 ) || exit $? -echo -echo '# Checking API compatibility.' -go tool api -c $GOROOT/api/go1.txt,$GOROOT/api/go1.1.txt -next $GOROOT/api/next.txt -except $GOROOT/api/except.txt +if [ -d "$GOROOT/src/cmd/api" ] +then + echo + echo '# Checking API compatibility.' + go tool api -c $GOROOT/api/go1.txt,$GOROOT/api/go1.1.txt -next $GOROOT/api/next.txt -except $GOROOT/api/except.txt +fi echo echo ALL TESTS PASSED -- 2.48.1