From ba99433d333a2babbbfa63ead19d43282a3243f4 Mon Sep 17 00:00:00 2001 From: Elias Naur Date: Fri, 16 Feb 2018 10:26:00 +0100 Subject: [PATCH] runtime: only run TestArenaCollision if the target can exec Replace the test for nacl with testenv.MustHaveExec to also skip test on iOS. Change-Id: I6822714f6d71533d1b18bbb7894f6ad339d8aea1 Reviewed-on: https://go-review.googlesource.com/94755 Run-TryBot: Elias Naur TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements --- src/runtime/malloc_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/runtime/malloc_test.go b/src/runtime/malloc_test.go index 091fc21199..854533f238 100644 --- a/src/runtime/malloc_test.go +++ b/src/runtime/malloc_test.go @@ -163,9 +163,8 @@ type acLink struct { var arenaCollisionSink []*acLink func TestArenaCollision(t *testing.T) { - if GOOS == "nacl" { - t.Skip("nacl can't self-exec a test") - } + testenv.MustHaveExec(t) + // Test that mheap.sysAlloc handles collisions with other // memory mappings. if os.Getenv("TEST_ARENA_COLLISION") != "1" { -- 2.50.0