From bb2f0da23ad77802f5a11b7670c66e644e48fcdc Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Mon, 18 Sep 2017 11:54:03 -0700 Subject: [PATCH] cmd/compile: fix compiler crash on recursive types By setting both a valid size and alignment for broken recursive types, we can appease some more safety checks and prevent compiler crashes. Fixes #21882. Change-Id: Ibaa137d8aa2c2a9d521462f144d7016c4abfd6e7 Reviewed-on: https://go-review.googlesource.com/64430 Run-TryBot: Matthew Dempsky TryBot-Result: Gobot Gobot Reviewed-by: Robert Griesemer --- src/cmd/compile/internal/gc/align.go | 1 + test/fixedbugs/issue21882.go | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 test/fixedbugs/issue21882.go diff --git a/src/cmd/compile/internal/gc/align.go b/src/cmd/compile/internal/gc/align.go index f29c587877..285d31dc6c 100644 --- a/src/cmd/compile/internal/gc/align.go +++ b/src/cmd/compile/internal/gc/align.go @@ -176,6 +176,7 @@ func dowidth(t *types.Type) { } t.Width = 0 + t.Align = 1 return } diff --git a/test/fixedbugs/issue21882.go b/test/fixedbugs/issue21882.go new file mode 100644 index 0000000000..f77e046960 --- /dev/null +++ b/test/fixedbugs/issue21882.go @@ -0,0 +1,9 @@ +// errorcheck + +// Copyright 2017 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package p + +type T [2]T // ERROR "invalid recursive type" -- 2.48.1