From bc21d6a4fcf2c957a3f279fa8725e16df6586864 Mon Sep 17 00:00:00 2001 From: James Yang <26634873@qq.com> Date: Tue, 23 May 2023 02:52:55 +0000 Subject: [PATCH] cmd/go/internal/modfetch: fix retractions slice initial length not zero When make slice of retractions, it should have initial length zero, to append more VersionIntervals. Currently without the zero length, the capacity used will be doubled after the appending, looks like a bug. Change-Id: Id3acaeffe557ca1d15c864b0377a66fee3a41f6c GitHub-Last-Rev: ed5fd5f6784c43195c531d8acc75560adff104ba GitHub-Pull-Request: golang/go#60354 Reviewed-on: https://go-review.googlesource.com/c/go/+/497118 Auto-Submit: Bryan Mills Reviewed-by: Bryan Mills Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov --- src/cmd/go/internal/modfetch/coderepo.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/go/internal/modfetch/coderepo.go b/src/cmd/go/internal/modfetch/coderepo.go index 50f4bb2b37..8fe432a9f5 100644 --- a/src/cmd/go/internal/modfetch/coderepo.go +++ b/src/cmd/go/internal/modfetch/coderepo.go @@ -1013,7 +1013,7 @@ func (r *codeRepo) retractedVersions(ctx context.Context) (func(string) bool, er if err != nil { return nil, err } - retractions := make([]modfile.VersionInterval, len(f.Retract)) + retractions := make([]modfile.VersionInterval, 0, len(f.Retract)) for _, r := range f.Retract { retractions = append(retractions, r.VersionInterval) } -- 2.50.0