From be9612a832186637173e35a2aa83ae193cf8d957 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Sun, 24 Jan 2021 21:26:14 -0800 Subject: [PATCH] [dev.regabi] os: disable TestDirFS until #42637 is fixed This test is causing nearly every trybot run on dev.regabi and dev.typeparams to fail. It's already a release blocker for Go 1.16, so the failures on the development branches is entirely noise; and because it causes the trybots to short-circuit, it risks masking actual Windows-specific failures. This CL disables the test until a proper solution is decided upon and implemented for Go 1.16. Updates #42637. Change-Id: Ibc85edaed591f1c125cf0b210867aa89d2b0a4b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/286213 Run-TryBot: Matthew Dempsky Trust: Matthew Dempsky Trust: Robert Griesemer TryBot-Result: Go Bot Reviewed-by: Than McIntosh Reviewed-by: Robert Griesemer --- src/os/os_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/os/os_test.go b/src/os/os_test.go index 698dbca91e..c02dc2c375 100644 --- a/src/os/os_test.go +++ b/src/os/os_test.go @@ -2689,6 +2689,9 @@ func TestOpenFileKeepsPermissions(t *testing.T) { } func TestDirFS(t *testing.T) { + if runtime.GOOS == "windows" { + t.Skip("workaround for dev.regabi/dev.typeparams until #42637 is fixed") + } if err := fstest.TestFS(DirFS("./testdata/dirfs"), "a", "b", "dir/x"); err != nil { t.Fatal(err) } -- 2.50.0