From bec8a108b324b2fc68eafeee7293a479813ec4e2 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 2 Feb 2022 10:19:30 -0500 Subject: [PATCH] runtime: skip TestSegv failures with "morestack on g0" on darwin/amd64 This failure mode has been present since at least 2020-06-08. We have enough information to diagnose it, and further failures don't seem to be adding any new information at this point: they can only add noise, both on the Go project's builders and in users' own modules (for example, when run as part of 'go test all'). For #39457 Change-Id: I2379631da0c8af69598fa61c0cc5ac0ea6ba8267 Reviewed-on: https://go-review.googlesource.com/c/go/+/382395 Trust: Bryan Mills Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui --- src/runtime/crash_cgo_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 9444554d37..dc8f6a7148 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -596,6 +596,9 @@ func TestSegv(t *testing.T) { t.Log(got) want := "SIGSEGV" if !strings.Contains(got, want) { + if runtime.GOOS == "darwin" && runtime.GOARCH == "amd64" && strings.Contains(got, "fatal: morestack on g0") { + testenv.SkipFlaky(t, 39457) + } t.Errorf("did not see %q in output", want) } -- 2.50.0