From c3bd93aa264383c0c7928516ca102a225c83ea23 Mon Sep 17 00:00:00 2001 From: Mikio Hara Date: Fri, 3 Jun 2016 18:06:54 +0900 Subject: [PATCH] net: don't leak test helper goroutine in TestAcceptTimeout Fixes #15109. Change-Id: Ibfdedd6807322ebec84bacfeb492fb53fe066960 Reviewed-on: https://go-review.googlesource.com/23742 Run-TryBot: Mikio Hara TryBot-Result: Gobot Gobot Reviewed-by: Marcel van Lohuizen --- src/net/timeout_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/net/timeout_test.go b/src/net/timeout_test.go index 14797eedb7..ed26f2a4af 100644 --- a/src/net/timeout_test.go +++ b/src/net/timeout_test.go @@ -5,6 +5,7 @@ package net import ( + "context" "fmt" "internal/testenv" "io" @@ -164,10 +165,13 @@ func TestAcceptTimeout(t *testing.T) { } defer ln.Close() + ctx, cancel := context.WithCancel(context.Background()) + defer cancel() for i, tt := range acceptTimeoutTests { if tt.timeout < 0 { go func() { - c, err := Dial(ln.Addr().Network(), ln.Addr().String()) + var d Dialer + c, err := d.DialContext(ctx, ln.Addr().Network(), ln.Addr().String()) if err != nil { t.Error(err) return -- 2.50.0