From c57cb7867e834136e55e7a2a171e1b7cc7cf34a0 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Mon, 20 Oct 2014 13:27:41 -0700 Subject: [PATCH] cmd/go: set exit status for failing "go generate" run. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/154360048 --- src/cmd/go/generate.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/generate.go b/src/cmd/go/generate.go index 167758207e..4227abbe7c 100644 --- a/src/cmd/go/generate.go +++ b/src/cmd/go/generate.go @@ -169,6 +169,7 @@ func (g *Generator) run() (ok bool) { if e != stop { panic(e) } + setExitStatus(1) } }() g.dir, g.file = filepath.Split(g.path) @@ -267,7 +268,8 @@ Words: var stop = fmt.Errorf("error in generation") // errorf logs an error message prefixed with the file and line number. -// It then exits the program because generation stops at the first error. +// It then exits the program (with exit status 1) because generation stops +// at the first error. func (g *Generator) errorf(format string, args ...interface{}) { fmt.Fprintf(os.Stderr, "%s:%d: %s\n", shortPath(g.path), g.lineNum, fmt.Sprintf(format, args...)) -- 2.50.0