From c67f9cc6c0753bf4aa994edfe09e869c7268b5d1 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Tue, 17 Mar 2020 10:22:41 -0400 Subject: [PATCH] [release-branch.go1.13] cmd/doc: skip failing TestDotSlashLookup on Windows This test was fixed by changing cmd/doc behavior in CL 204442. Backporting that non-test code change is unlikely to be appropriate this late in Go 1.13 release cycle. A failing test can cover up other regressions, so skip this known failing test to fix the builder. For #35236. For #36181. Change-Id: I07e795e75d7e37bc96ab68607d5d5cc9254342f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/223780 Run-TryBot: Dmitri Shuralyov Reviewed-by: Alexander Rakoczy Reviewed-by: Carlos Amedee --- src/cmd/doc/doc_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go index 11d0bdafd9..9a5c04fe4c 100644 --- a/src/cmd/doc/doc_test.go +++ b/src/cmd/doc/doc_test.go @@ -920,6 +920,9 @@ func TestDotSlashLookup(t *testing.T) { t.Skip("scanning file system takes too long") } maybeSkip(t) + if runtime.GOOS == "windows" { + t.Skip("known Windows test failure on release-branch.go1.13; fix is in CL 204442 but requires non-test code changes unlikely to be appropriate for backporting this late") + } where, err := os.Getwd() if err != nil { t.Fatal(err) -- 2.50.0