From c692f752b5b78b919e11f3fccf158bc7dc17920b Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Fri, 16 Apr 2021 10:17:34 +0200 Subject: [PATCH] cmd/link/internal/ld: re-enable tests on darwin It looks like these are fixed again for darwin on current tip after CL 111258 marked them to be skipped. Updates #23168 Change-Id: I4abecee1152ccd4f2d44d76d1acdecb0d6140981 Reviewed-on: https://go-review.googlesource.com/c/go/+/308994 Trust: Tobias Klauser Run-TryBot: Tobias Klauser TryBot-Result: Go Bot Reviewed-by: Than McIntosh --- src/cmd/link/internal/ld/dwarf_test.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/cmd/link/internal/ld/dwarf_test.go b/src/cmd/link/internal/ld/dwarf_test.go index e845a95359..56dc4753b2 100644 --- a/src/cmd/link/internal/ld/dwarf_test.go +++ b/src/cmd/link/internal/ld/dwarf_test.go @@ -610,8 +610,8 @@ func TestInlinedRoutineRecords(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } - if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" || runtime.GOOS == "darwin" { - t.Skip("skipping on solaris, illumos, and darwin, pending resolution of issue #23168") + if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" { + t.Skip("skipping on solaris, illumos, pending resolution of issue #23168") } t.Parallel() @@ -847,8 +847,8 @@ func TestAbstractOriginSanity(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } - if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" || runtime.GOOS == "darwin" { - t.Skip("skipping on solaris, illumos, and darwin, pending resolution of issue #23168") + if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" { + t.Skip("skipping on solaris, illumos, pending resolution of issue #23168") } if wd, err := os.Getwd(); err == nil { @@ -865,8 +865,8 @@ func TestAbstractOriginSanityIssue25459(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } - if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" || runtime.GOOS == "darwin" { - t.Skip("skipping on solaris, illumos, and darwin, pending resolution of issue #23168") + if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" { + t.Skip("skipping on solaris, illumos, pending resolution of issue #23168") } if runtime.GOARCH != "amd64" && runtime.GOARCH != "386" { t.Skip("skipping on not-amd64 not-386; location lists not supported") @@ -886,8 +886,8 @@ func TestAbstractOriginSanityIssue26237(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } - if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" || runtime.GOOS == "darwin" { - t.Skip("skipping on solaris, illumos, and darwin, pending resolution of issue #23168") + if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" { + t.Skip("skipping on solaris, illumos, pending resolution of issue #23168") } if wd, err := os.Getwd(); err == nil { gopathdir := filepath.Join(wd, "testdata", "issue26237") -- 2.50.0