From c6f33ed11353620201fa2d4df40dd7304282539d Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Fri, 19 May 2023 23:20:43 -0400 Subject: [PATCH] cmd/dist: make two related panic messages more consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In contrast to the HasSuffix argument, there's no need or benefit in having a ":" before the "racebench" variant mentioned in the message. (The variant comes after the colon separator—it doesn't include it.) Change-Id: Ie9948104de9449422037bf39245944255b98f1b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/497735 Run-TryBot: Dmitri Shuralyov TryBot-Result: Gopher Robot Auto-Submit: Dmitri Shuralyov Reviewed-by: Austin Clements --- src/cmd/dist/test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 849dad3640..3384149391 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -834,7 +834,7 @@ func (t *tester) addTest(name, heading string, fn func(*distTest) error) { if !strings.Contains(name, ":") && heading != "Testing packages." { panic("empty variant is reserved exclusively for registerStdTest") } else if strings.HasSuffix(name, ":racebench") && heading != "Running benchmarks briefly." { - panic(":racebench variant is reserved exclusively for registerRaceBenchTest") + panic("racebench variant is reserved exclusively for registerRaceBenchTest") } if t.testNames == nil { t.testNames = make(map[string]bool) -- 2.48.1