From c6fef1fb52e9660ce2226a19508fdaacf71e46a9 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Sat, 7 Mar 2020 13:36:36 -0800 Subject: [PATCH] cmd/compile: improve CFG size in ssa.html This change forces CFGs to take the full width of their column and allows them to be as tall as necessary. In my (recent) experience, this makes them far less likely to be cropped, which makes them much more useful. On rare occasions, this can lead to gigantic CFGs, but if you've bothered to explicitly request a CFG, this is still better than an irrevocably truncated CFG. Change-Id: I9a649ea57fa3c2792998bb71331a2580e429b36a Reviewed-on: https://go-review.googlesource.com/c/go/+/222618 Reviewed-by: Cherry Zhang --- src/cmd/compile/internal/ssa/html.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/compile/internal/ssa/html.go b/src/cmd/compile/internal/ssa/html.go index c384817d0c..54fa54a477 100644 --- a/src/cmd/compile/internal/ssa/html.go +++ b/src/cmd/compile/internal/ssa/html.go @@ -245,6 +245,7 @@ dd.ssa-prog { svg { cursor: default; outline: 1px solid #eee; + width: 100%; } body.darkmode { @@ -975,7 +976,7 @@ func (d *dotWriter) writeFuncSVG(w io.Writer, phase string, f *Func) { fmt.Println(err) return } - fmt.Fprint(pipe, `digraph "" { margin=0; size="4,40"; ranksep=.2; `) + fmt.Fprint(pipe, `digraph "" { margin=0; ranksep=.2; `) id := strings.Replace(phase, " ", "-", -1) fmt.Fprintf(pipe, `id="g_graph_%s";`, id) fmt.Fprintf(pipe, `node [style=filled,fillcolor=white,fontsize=16,fontname="Menlo,Times,serif",margin="0.01,0.03"];`) -- 2.50.0