From c7233dd063cd8bf24460b280e3929458e64f4315 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Kai=20L=C3=BCke?= Date: Mon, 16 Nov 2020 12:05:13 +0000 Subject: [PATCH] cmd/go: permit wrongly rejected -Wl,-O... linker flags A typo caused the validation rule to check against -WL,-O... which is not a regular flag because the L should be lowercase as in the other rules. This caused valid linker flags to be rejected and people had to work around this by filtering their default flags that include, e.g., -Wl,-O1 for a simple link optimization. Fix the typo that wrongly rejected -Wl,-O... but allowed a non-existing -WL,-O flag. Change-Id: Ia3bf730f16f5ad98a39d7f17159de17b44075462 GitHub-Last-Rev: 2ec7f2a2b92c9c76e707a71f6c5273aa1d512006 GitHub-Pull-Request: golang/go#42631 Reviewed-on: https://go-review.googlesource.com/c/go/+/270278 Run-TryBot: Ian Lance Taylor TryBot-Result: Go Bot Reviewed-by: Jay Conrod Reviewed-by: Ian Lance Taylor Trust: Jay Conrod --- src/cmd/go/internal/work/security.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/go/internal/work/security.go b/src/cmd/go/internal/work/security.go index b8df3dddd3..36bbab37ee 100644 --- a/src/cmd/go/internal/work/security.go +++ b/src/cmd/go/internal/work/security.go @@ -179,7 +179,7 @@ var validLinkerFlags = []*lazyregexp.Regexp{ re(`-Wl,-berok`), re(`-Wl,-Bstatic`), re(`-Wl,-Bsymbolic-functions`), - re(`-WL,-O([^@,\-][^,]*)?`), + re(`-Wl,-O([^@,\-][^,]*)?`), re(`-Wl,-d[ny]`), re(`-Wl,--disable-new-dtags`), re(`-Wl,-e[=,][a-zA-Z0-9]*`), -- 2.50.0